[KYUUBI #1509] Make KYUUBI_WORK_DIR_ROOT as the default root path. #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will it work properly for cluster mode？ when KYUUBI_WORK_DIR_ROOT only exists on server node but is passed to a remote engine |
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
============================================
- Coverage 59.38% 59.21% -0.18%
Complexity 172 172
============================================
Files 238 241 +3
Lines 12168 12192 +24
Branches 1491 1496 +5
============================================
- Hits 7226 7219 -7
- Misses 4331 4359 +28
- Partials 611 614 +3
Continue to review full report at Codecov.
|
When only KYUUBI_WORK_DIR_ROOT is configured, it can work properly for cluster mode. Related screenshots: #1509 (comment) Under what circumstances will environment variables be passed to remote engine? |
yaooqinn
approved these changes
Dec 7, 2021
yaooqinn
pushed a commit
that referenced
this pull request
Dec 7, 2021
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> Make KYUUBI_WORK_DIR_ROOT as the default root path. For details: #1509. ### _How was this patch tested?_ - [X] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [X] Add screenshots for manual tests if appropriate - [X] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1519 from wForget/KYUUBI-1509. Closes #1509 ff078e5 [Wang Zhen] [KYUUBI-1509] Make KYUUBI_WORK_DIR_ROOT as the default root path. Authored-by: Wang Zhen <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 986d983) Signed-off-by: Kent Yao <[email protected]>
|
thanks, merged to master and v1.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Make KYUUBI_WORK_DIR_ROOT as the default root path. For details: #1509.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request